Open tnull opened 2 months ago
Hi @tnull, I'd like to pick this up if no one is currently assigned to or working on it.
Hi @tnull, I'd like to pick this up if no one is currently assigned to or working on it.
Cool! Sure, go for it!
Note that in contrary to what I wrote above, we may want to expose this as an Option<String>
and make sure we sanitize it before setting the alias. This will of course take away some degrees of freedom from our users, but also incentivize not to set some bogus/dangerous aliases that might be parsed wrongly by other network participants.
Moreover, we might want to consider only broadcasting node announcements if both the node alias and valid (public) socket addresses are set.
We should add a
Config
field allowing to set the alias a node would use in its announcement.For bindings, we'll need to make this aVec<u8>
. We could consider making this anOption<Vec<u8>>
and refuse to a) open public channels if it's unset b) startup with public channels if it's unset or doesn't fit in the[u8; 32]
.