Previously, OnchainPayment::send_all_to_address could only be used to fully drain the onchain wallet, i.e., would not retain any reserves.
Here, we try to introduce a retain_reserves bool that allows users to send all funds while honoring the configured on-chain reserves. While we're at it, we move the reserve checks for send_to_address also to the internal wallet's method, which makes the checks more accurate as they now are checked against the final transaction value, including transaction fees.
~This was requested by a user, but I'm a bit on the fence if we actually should move forward with it: for one, figuring out the spendable amount above the reserve is always gonna be inexact compared to draining the wallet.~
~Moreover, adding this to our API might send the wrong message of the reserve value being an exact value, while it's always on the safer side to maintain a larger reserve.~
tnull
commented
2 weeks ago
Previously,
OnchainPayment::send_all_to_addresscould only be used to fully drain the onchain wallet, i.e., would not retain any reserves.Here, we try to introduce a
retain_reservesbool that allows users to send all funds while honoring the configured on-chain reserves. While we're at it, we move the reserve checks forsend_to_addressalso to the internal wallet's method, which makes the checks more accurate as they now are checked against the final transaction value, including transaction fees.~This was requested by a user, but I'm a bit on the fence if we actually should move forward with it: for one, figuring out the spendable amount above the reserve is always gonna be inexact compared to draining the wallet.~
~Moreover, adding this to our API might send the wrong message of the reserve value being an exact value, while it's always on the safer side to maintain a larger reserve.~