lightningdevkit / ldk-node

A ready-to-go node implementation built using LDK.
Other
140 stars 72 forks source link

Allow setting payment_id in send and send_using_amount in bolt11 send. #346

Open G8XSU opened 3 weeks ago

G8XSU commented 3 weeks ago

This is required to ensure idempotency in send_payment requests.

tnull commented 3 weeks ago

I don't think want to allow users to set their own payment ID as we derive it differently for different payment types and use it as an index in the payment store. I'm not quite sure how this is connected to idempotency? Could you expand in which context this came up?