search

lightningdevkit / ldk-node

A ready-to-go node implementation built using LDK.
Other
148 stars 80 forks source link

Offer `serde` support for public types #75

Open tnull opened 1 year ago

tnull commented 1 year ago

We should consider adding a serde feature similar to rust-bitcoin that allows the public types to be easily integrated by anyone using serde.

tnull commented 1 year ago

While not exactly blocking, we may want to wait until it has been decided upstream whether we'll integrate a lightning-types crate upstream.

tnull commented 4 months ago

Probably not going to do this since we haven't user requests for it so far, so closing for now. Can always revisit in the future if someone actually would benefit from it.

amackillop commented 4 months ago

I'd like to have this feature. If you have greater priorities I can try adding it myself

tnull commented 4 months ago

I'd like to have this feature. If you have greater priorities I can try adding it myself

Cool, yeah, that would be greatly appreciated. Reopening.

amackillop commented 4 months ago

Made a PR to rust-lighting as a first step for the types that are re-exported here