search

lightningdevkit / ldk-review-club

LDK Review Club Website
6 stars 5 forks source link

2760 #27

Closed jbesraa closed 8 months ago

jbesraa commented 9 months ago

@dunxen

review club for https://github.com/lightningdevkit/rust-lightning/pull/2760

netlify[bot] commented 9 months ago

Deploy Preview for courageous-frangipane-fab648 ready!

Name Link
Latest commit 3e9f89aeb710d10b48841650b52a86f832896c0b
Latest deploy log https://app.netlify.com/sites/courageous-frangipane-fab648/deploys/65954e417b21f50008de697b
Deploy Preview https://deploy-preview-27--courageous-frangipane-fab648.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dunxen commented 9 months ago

Thanks, @jbesraa! Looking good so far. Did you want a little more time to flesh out the other questions on V2 establishment or do you need some assistance? I think we don't really need to focus on V1 vs V2 stuff here and rather dig deeper into the cause of the bug! :D

jbesraa commented 9 months ago

Thanks, @jbesraa! Looking good so far. Did you want a little more time to flesh out the other questions on V2 establishment or do you need some assistance? I think we don't really need to focus on V1 vs V2 stuff here and rather dig deeper into the cause of the bug! :D

Yea no problem. I dont have other questions to add here really, so feel free to add yours if you have something in mind.

Are we planning to run this tomorrow?

dunxen commented 8 months ago

LGTM if you're happy! I'll merge and then we can still make adjustments if needed. At least we can make the announcement today.