search

lightningdevkit / ldk-sample

Sample node implementation using LDK
Apache License 2.0
166 stars 94 forks source link

persist payments info to disk #104

Closed zoedberg closed 1 year ago

zoedberg commented 1 year ago

This PR should close https://github.com/lightningdevkit/ldk-sample/issues/90.

I hope the way I implemented this meets the goals of the sample (simplicity and readibility). I was a bit unsure on some styling details, if there's something you would like to be implemented differently I'd be happy to change it.

tnull commented 1 year ago

Thanks for having a go at this! I believe this unfortunately now needs a rebase!

zoedberg commented 1 year ago

No problem, it was an easy rebase!

zoedberg commented 1 year ago

@TheBlueMatt could you please check if this can now be merged?

zoedberg commented 1 year ago

Grrrr, I am so sorry I missed this again somehow. It basically looks good to me with one missed update. When you push next, feel free to squash the fixup commits down into one commit.

No worries and thank you for the thorough review. I've fixed and squashed the fixup commits

zoedberg commented 1 year ago

@TheBlueMatt I've squashed the commits into a single one

zoedberg commented 1 year ago

And also rebased since I've just noticed commit was not on top of current main