search

lightningdevkit / ldk-sample

Sample node implementation using LDK
Apache License 2.0
166 stars 94 forks source link

Fix build errors and warnings on Windows operating system #111

Closed kandycoder closed 1 year ago

kandycoder commented 1 year ago
  1. Bumping the dependency version of tokio fixes a compile error in ntexapi.rs (see https://stackoverflow.com/questions/76173195/my-rust-project-is-broken-all-of-the-sudden)
  2. Switching from std::env::home_dir() to home::home_dir() clears warnings about deprecation and unexpected behavior pertaining to Windows only.
kandycoder commented 1 year ago

Not sure why some CI builds failed. The home crate is used by Rust and Cargo themselves and should be good. And why the Windows build failed on something unrelated I have no idea. EDIT: Probably your CI needs a newer Cargo version...so there's not much I can do about that.

TheBlueMatt commented 1 year ago

Probably your CI needs a newer Cargo version...so there's not much I can do about that.

We support a relatively liberal MSRV to ensure the project "just builds" on most systems, so indeed we can't land this as-is.

TheBlueMatt commented 1 year ago

Closing as stale.