search

lightningdevkit / ldk-sample

Sample node implementation using LDK
Apache License 2.0
166 stars 94 forks source link

workflow:add checkout parameters to fix inconsistent build failures #128

Open RandyMcMillan opened 8 months ago

RandyMcMillan commented 8 months ago

https://github.com/bitcoincore-dev/ldk-sample/actions/runs/7806359956/job/21292554030

TheBlueMatt commented 8 months ago

The error upstream was "fatal: unable to access 'https://github.com/lightningdevkit/ldk-sample/': Could not resolve host: github.com". I don't see how this fixes the error of "sorry, not connected to the internet"?

RandyMcMillan commented 8 months ago

I have found that if git doesn't recognize a repo as safe...it blocks requests. So the error may be being misinterpreted by GitHub?

TheBlueMatt commented 8 months ago

I'm somewhat skeptical, my PR at https://github.com/lightningdevkit/ldk-sample/actions/runs/7806655220/job/21293476669?pr=129 just passed fine. We've seen github MacOS runners not have internet connectivity sporadically repeatedly in other LDK projects, though, so I think the bug actually lies on GitHub's end. Unless there's some other reference to this issue I'm not aware of.

RandyMcMillan commented 8 months ago

I understand your skepticism. Whenever I create a workflow - I just automatically put it in there. So it isn't even an issue. Feel free to gank the commit and try it on other repos YOU are seeing this intermittent issue on - with no real explanation or solution.