search

lightningdevkit / ldk-sample

Sample node implementation using LDK
Apache License 2.0
166 stars 94 forks source link

Update to LDK 0.0.123 #133

Closed valentinewallace closed 4 months ago

TheBlueMatt commented 5 months ago

Oh, wait, no, we need to replace our sweeper with the upstream one now.

valentinewallace commented 5 months ago

Oh, wait, no, we need to replace our sweeper with the upstream one now.

Oops! Will push an update for this.

valentinewallace commented 5 months ago

CI failed due to https://github.com/rust-lang/rust/issues/63033, pushed a fixup. Not sure our stance on raising the MSRV of the sample but it seems the bug is fixed in 1.69.

TheBlueMatt commented 5 months ago

I feel fine with the fix, its not wildly intrusive, as long as we leave a comment linking to the rustc issue.

valentinewallace commented 5 months ago

Added a comment for the rust bug and tweaked the TODO regarding periodic_sweep.

valentinewallace commented 5 months ago

Updated from using the RC to the release.

valentinewallace commented 4 months ago

Apologies @tnull I totally missed that review. Updated!