lightningdevkit / ldk-sample

Sample node implementation using LDK
Apache License 2.0
166 stars 94 forks source link

Fix bitcoind_client:: send_raw_transaction #27

Closed sr-gi closed 3 years ago

sr-gi commented 3 years ago

bitcoind_client:: send_raw_transaction receives a RawTx and calls rpc.call_method expecting a return of the same type (rpc.call_method::<RawTx>...).

This feels wrong*, given sendrawtransaction returns a txid if successful. It may make more sense to pass a RawTx to send_raw_transaction and returning a TxidHex or something of those lines.

*Notice this actually works given RawTx is simply a wrapper around String.