search

lightningdevkit / ldk-sample

Sample node implementation using LDK
Apache License 2.0
166 stars 94 forks source link

Makes send_raw_transaction return TxidHex instead of RawTx #28

Closed sr-gi closed 3 years ago

sr-gi commented 3 years ago

bitcoind_client::send_raw_transaction was returning RawTx which, while syntactically correct, made no sense conceptually.

Creates a new conversion type (TxidHex) and makes sendrawtransaction return it instead.

close #27

valentinewallace commented 3 years ago

Could update this now that the dependent upstream PR is merged :)

sr-gi commented 3 years ago

Could update this now that the dependent upstream PR is merged :)

Will do!

Should I split this into two PRs (one for Txid and another one for Transaction), or should I push the Transaction changes upstream and leave this open until that's also merged?

jkczyz commented 3 years ago

Should I split this into two PRs (one for Txid and another one for Transaction), or should I push the Transaction changes upstream and leave this open until that's also merged?

Either is fine by me.