Sample v0 - Githubissues

lightningdevkit / ldk-sample

Sample node implementation using LDK

Apache License 2.0

166 stars 94 forks source link

Sample v0 #4

Closed valentinewallace closed 3 years ago

valentinewallace commented 3 years ago

TODOs

[x] fix forwarding a payment from lnd --> lnd through this node (not sure why this doesn't work right now, even if we set announce_channel = true it results in a no_route_found error from lnd)
[x] in cli::send_payment -- use the route hints from the invoice
[x] get this based on https://github.com/rust-bitcoin/rust-lightning/pull/863

TheBlueMatt commented 3 years ago

nit: there is a bunch of inconsistent whitespace here, does it make since to use rustfmt (do you like its formatting in this crate?) or, if not, it might be useful to have this in vimrc (depending on your terminal settings):

au BufEnter * hi Tab ctermbg=black
au BufEnter * syntax match Tab /\t/

valentinewallace commented 3 years ago

This is good for more review!

jkczyz commented 3 years ago

Could you squash any fixup commits? Feel free to squash everything in one commit if that makes the most sense.

valentinewallace commented 3 years ago

Could you squash any fixup commits? Feel free to squash everything in one commit if that makes the most sense.

Squashed!