lightningdevkit / ldk-sample

Sample node implementation using LDK
Apache License 2.0
166 stars 94 forks source link

Parse .env or environment variables for RPC auth details #49

Closed arik-so closed 1 year ago

arik-so commented 2 years ago

And possibly for other properties, too, such that not every single launch has to be a super long command, and such that the auth data doesn't get added to the command history.

TheBlueMatt commented 2 years ago

We...don't have an RPC? I'm not sure what auth details we'd want to parse?

arik-so commented 2 years ago

The auth to talk to the bitcoin daemon RPC :)

TheBlueMatt commented 2 years ago

Oh, yea, duh, would be cool to parse the .cookie.

alecchendev commented 1 year ago

Hello! I’m interested in picking up this issue. Worked with Rust a bit in the past but otherwise fairly new. Also new to contributing to open-source.

Here’s what I’m considering for a basic version that parses RPC fields from a .env file:

Question: Is there a recommended way for testing changes in this repo?

If anyone has feedback/questions on this it'd be greatly appreciated! I plan to get a PR in for the basic version either tonight or tomorrow sometime, then possibly expand to other arguments after I get that working.

TheBlueMatt commented 1 year ago

Done in #87