search

lightningdevkit / ldk-sample

Sample node implementation using LDK
Apache License 2.0
166 stars 94 forks source link

Semantically sort subcommands with headings #75

Closed ch1ru closed 1 year ago

ch1ru commented 2 years ago

Added headings to subcommands and version info into the help menu. This makes the menu more intuitive and similar to LND help menu.

G8XSU commented 2 years ago

Also, while you are at it, it might be helpful to add a section in README on usage. Its very slim currently.

valentinewallace commented 1 year ago

Sorry @ch1ru, mind fixing the rustfmt CI error? I didn't realize CI hadn't ran

TheBlueMatt commented 1 year ago

Looks like this needs rebase now as well, sorry about that.

ch1ru commented 1 year ago

Do I need to open this pr again to fix the error?

tnull commented 1 year ago

Do I need to open this pr again to fix the error?

No, you can just rebase on current main (e.g., by git rebase -i origin/main and resolving any conflicts) and then git push --force) the branch to update this PR.

ch1ru commented 1 year ago

@tnull Thanks, and is there a way I can run the CI checks again to make sure the changes have no conflicts?

tnull commented 1 year ago

@tnull Thanks, and is there a way I can run the CI checks again to make sure the changes have no conflicts?

Generally you can find the exact checks that will run here, but in this repo you really just want to run cargo build and cargo fmt before pushing and ensure that they don't return any errors.