search

lightningdevkit / ldk-sample

Sample node implementation using LDK
Apache License 2.0
166 stars 94 forks source link

Update to LDK version 0.0.114 #97

Closed valentinewallace closed 1 year ago

valentinewallace commented 1 year ago

Blocked on LDK release.

TheBlueMatt commented 1 year ago

Other than the above comments, LGTM, should be able to land now that 114 is out!

TheBlueMatt commented 1 year ago

Oh should we also switch to the async background processor now because we are running in tokio anyway?

valentinewallace commented 1 year ago

Oh should we also switch to the async background processor now because we are running in tokio anyway?

Sure. Would this be for dogfooding purposes or is it better suited to the task?

TheBlueMatt commented 1 year ago

Sure. Would this be for dogfooding purposes or is it better suited to the task?

Bit of both, but, yea, for tokio it means we remove a thread which is nice.

TheBlueMatt commented 1 year ago

Ah, we cant move to the async BP cause of https://github.com/lightningdevkit/rust-lightning/issues/2003