lightningdevkit / ldk-sample

Sample node implementation using LDK
Apache License 2.0
166 stars 94 forks source link

Don't panic on tx broadcast failures #99

Closed TheBlueMatt closed 1 year ago

TheBlueMatt commented 1 year ago

In general LDK will often broadcast transactions which aren't actually able to get into the mempool. That's generally fine, though could indicate a significant issue. Thus, we previously had a panic in place for it to ensure developers are notified and we can investigate.

However, now that people are trying to actually use ldk-sample, we should just remove the panic and print something with more details.

TheBlueMatt commented 1 year ago

Mmm, that's a good point, went ahead and did that.

wpaulino commented 1 year ago

CI is failing on the rustfmt check

TheBlueMatt commented 1 year ago

Sorry, yea.