lightningdevkit / lightning-liquidity

Other
27 stars 17 forks source link

LSPS 0/1/2: Ensure all sat/msat fields are de/serialized from/to "string" #107

Closed tnull closed 6 months ago

tnull commented 6 months ago

The spec mandates that monetary amounts are represented as JSON strings on the wire, but that implementations SHOULD represent them as u64 internally. See https://github.com/BitcoinAndLightningLayerSpecs/lsp/blob/main/LSPS0/common-schemas.md#monetary-amounts

We need to double-check that we adhere to these rules everywhere.

tnull commented 6 months ago

Assigning myself here, will pick this up soon.