lightningdevkit / lightning-liquidity

Other
27 stars 17 forks source link

LSPS1: Make more optional fields explicitly optinonal instead of leaning on serde. #65

Closed tnull closed 6 months ago

tnull commented 11 months ago

There are a few instances where some fields are optional and/or may not be present and we currently seem to lean on serde ignoring unrecognized fields. We should try to make these fields explicitly optional if possible. Some examples would OptionsSupported or OrderPayment::onchain_payment, however, I expect the latter case has to be made optional anyways.