search

lightningdevkit / lightning-liquidity

Other
27 stars 17 forks source link

LSPS1: Potentially superfluous `GetOrderResponse` #66

Closed tnull closed 8 months ago

tnull commented 11 months ago

The LSP's response to a GetOrderRequest is the same object as to CreateOrder. I'm a bit dubious why we require it in a separate GetOrderResponse object.

Srg213 commented 10 months ago

Yes I agree. I followed the naming convention in the spec and as mentioned, all of the fields of both GetOrderResponse and CreateOrderResponse are the same. LSP updates the order_status and channel parameters in the latter object. Maybe the latter object should be pasesd as mut and *ref, not sure.