search

lightningdevkit / lightning-liquidity

Other
27 stars 17 forks source link

take and hold a reference to ChannelManager #9

Closed johncantrell97 closed 1 year ago

johncantrell97 commented 1 year ago

There's no real need for the LiquidityManager to actually hold the channel manager. Once LSPS1 and/or LSPS2 are landed we should remove the reference from LiquidityManager as the reference will just pass through to the constructors of the protocols.

Instead of putting the type constraints on just the new method, this way is closer to what it will actually look like once the LiquidityManager will hold LSPS1/2 objects that have these same generics.

tnull commented 1 year ago

The CI failure should be due to https://github.com/lightningdevkit/ldk-lsp-client/pull/10. Feel free to rebase this PR after it has been merged.

johncantrell97 commented 1 year ago

Rebased, thanks