lightningdevkit / lightningdevkit.org

Lightning Development Kit Documentation
https://lightningdevkit.org
MIT License
59 stars 39 forks source link

Update Fee Estimation Docs #277

Closed Beige-Coffee closed 2 weeks ago

Beige-Coffee commented 2 months ago

This PR updates the Fee Estimation docs, incorporating the new ConfirmationTargets outlined in this PR.

Changes are the following:

  1. Updated the ConfirmationTarget table with new Confirmation Targets (MaximumFeeEstimate, UrgentOnChainSweep)
  2. Added commentary to Best Practices and Off-Chain sections regarding how to understand and populate MaximumFeeEstimate.
netlify[bot] commented 2 months ago

Deploy Preview for lightningdevkit ready!

Name Link
Latest commit 399ca1c38c0fae3ed633fe25f95fb82af580e143
Latest deploy log https://app.netlify.com/sites/lightningdevkit/deploys/66da3efcbc31af0008c5fb65
Deploy Preview https://deploy-preview-277--lightningdevkit.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Beige-Coffee commented 2 months ago

@ConorOkus & @jkczyz - just giving a heads up that I updated the Fee Estimation docs per Matt's PR from a week or so ago.

I have one question for the group (+ @TheBlueMatt): Does anyone have suggestions regarding the MaximumFeeEstimate entry in the ConfirmationTarget table? Currently, I've added the below. If there are no suggestions, then we should be good to go!

ConfirmationTarget mempool.space Category Number of Blocks
MaximumFeeEstimate fastestFee 1