search

lightningdevkit / rust-lightning

A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
Other
1.16k stars 367 forks source link

Ability to construct an invoice from bindings #1868

Open TheBlueMatt opened 1 year ago

TheBlueMatt commented 1 year ago

Most languages don't support move semantics, so the standard rust builder pattern doesn't work. Worse, the invoice construction builder has a ton of type info that enforces downstream correctness. Realistically, we probably need to expose a full #[cfg(c_bindings)] invoice constructor that is parallel with the rust one.

TheBlueMatt commented 1 year ago

Gonna slip this.

TheBlueMatt commented 1 year ago

Slipping to 0.1.

TheBlueMatt commented 6 months ago

Surprisingly, with the utils, no one has actually complained about this, so removing the milestone entirely.