lightningdevkit / rust-lightning

A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
Other
1.15k stars 364 forks source link

Wake background-processor on async monitor update completion #2052

Closed TheBlueMatt closed 1 year ago

TheBlueMatt commented 1 year ago

Probably need some kinda future like we have for ChannelManager persistence. We should also improve the logging in monitor persistence.

TheBlueMatt commented 1 year ago

Note to self, starting point branch with logging: 2023-02-better-chain-monitor-logging

MaxFangX commented 1 year ago

It would be great if this new future is broad enough that the 100ms sleeper future in the LDK background processor could be removed (or at least default to a much higher value, like once a minute). Even though we don't use LDK's background processor directly, it would be a strong signal to us that LDK has confidence in its provided mechanisms for waking the background processor when needed, and would thus give us the confidence to remove our process events timer downstream.