search

lightningdevkit / rust-lightning

A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
Other
1.11k stars 342 forks source link

Panic-during-panic in `lightning-background-processor` tests #2759

Open arik-so opened 7 months ago

arik-so commented 7 months ago

https://github.com/lightningdevkit/rust-lightning/actions/runs/6950309022/job/18910198951?pr=2736

TheBlueMatt commented 7 months ago

Specifically, the following, which indicates either a panic-during-panic or unsafe code doing its unsafe thing. It was in lightning-background-processor, though.

 Caused by:
  process didn't exit successfully: `/Users/runner/work/rust-lightning/rust-lightning/target/debug/deps/lightning_background_processor-77ce9b182df3c537` (signal: 6, SIGABRT: process abort signal)
arik-so commented 7 months ago

Is it fair to assume that it's caused by one of the four remaining unnamed unit tests within that group?

TheBlueMatt commented 7 months ago

Its one of any tests aside from the ones that passed:

test tests::test_channel_manager_persist_error ... ok
test tests::test_channel_manager_persist_error_async ... ok
test tests::test_network_graph_persist_error ... ok
test tests::test_background_event_handling ... ok
test tests::test_background_processor ... ok
test tests::test_payment_path_scoring ... ok
test tests::test_not_pruning_network_graph_until_graph_sync_completion_async ... ok
test tests::test_scorer_persist_error ... ok
test tests::test_not_pruning_network_graph_until_graph_sync_completion ... ok