search

lightningdevkit / rust-lightning

A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
Other
1.12k stars 349 forks source link

Rework/increase scoring params #3040

Open TheBlueMatt opened 3 months ago

TheBlueMatt commented 3 months ago

I think we were a little too conservative on our scoring params and we end up too strongly preferring to avoid fees, when most lightning users actually expect to pay some fees for reliable payments. We should probably at least double our fee params.

benthecarman commented 2 months ago

FWIW we need to increase them much more than 2x and still have some reliability issues

https://github.com/MutinyWallet/mutiny-node/blob/68d545d1f82ba0d0e64980d056dc16ee7f00d457/mutiny-core/src/node.rs#L1943

TheBlueMatt commented 2 months ago

Thanks, that's helpful. So it looks like you multiply the base penalty by 200, the based penalty amount multiplier by 100, and all 4 liquidity penalties by 15. Those are probably good numbers for us to start with, though not sure we'll want to crank the base penalties up quite that high.

and still have some reliability issues

I assume this is with rather aggressive probing, correct? Have you tried any major variations from the parameters you have listed there to see if things improve? I'm particularly curious if you reduce the liquidity_penalty parameters and increase the historical_liquidity_penalty parameters to compensate if that improves things.