search

lightningdevkit / rust-lightning

A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
Other
1.17k stars 368 forks source link

Gossip never seems to get a full take from Eclair/CLN #3075

Open TheBlueMatt opened 6 months ago

TheBlueMatt commented 6 months ago

We've seen a handful of reports that seem to indicate we don't succeed fetching gossip from CLN/Eclair. If I had to guess its because they don't sort the gossip into channel_announcements first, then channel_updates, then node_announcements, as required by the spec.

rustyrussell commented 2 weeks ago

We definitely do order it correctly. We do ratelimit to 1Mbyte/sec these days though?

vincenzopalazzo commented 2 weeks ago

We do ratelimit to 1Mbyte/sec these days though?

Probably someone is impacted, but not everyone. LDK is syncing correctly. Probably the problem that we are discussing here is a problem that people do not see channel_announcements that is a similar problem that I nodded between cln nodes

Working on producing a gossip observer tool in the next coming days (more weeks)

TheBlueMatt commented 2 weeks ago

Yea, I think its quite likely just that the peer in question doesn't have the whole gossip map. I guessed it was ordering because we get a lot of errors that look like ordering errors - is it possible that CLN (or others?) relay live channel_update gossip for SCID X when it is still doing a historical sync and hasn't yet reached X, thus making the channel_update an out-of-order error?