search

lightningdevkit / rust-lightning

A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
Other
1.15k stars 363 forks source link

Move accept_channel checks into `ChannelContext::do_accept_channel_checks` #3123

Closed dunxen closed 3 months ago

dunxen commented 3 months ago

This is done ahead of getting the dual-funding implementation to reduce refactoring noise there.

See #2302.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 75.20000% with 31 lines in your changes missing coverage. Please review.

Project coverage is 89.90%. Comparing base (07f3380) to head (0881b24).

Files Patch % Lines
lightning/src/ln/channel.rs 75.20% 29 Missing and 2 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3123 +/- ## ========================================== - Coverage 89.90% 89.90% -0.01% ========================================== Files 121 121 Lines 99170 99181 +11 Branches 99170 99181 +11 ========================================== + Hits 89159 89164 +5 + Misses 7408 7407 -1 - Partials 2603 2610 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.