Closed optout21 closed 3 months ago
Attention: Patch coverage is 88.57143%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 91.15%. Comparing base (
07f3380
) to head (43a6ee3
). Report is 31 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Pushed some minor fuzz fixes; ready for review.
Some changes to the splice messages according to new spec draft https://github.com/lightning/bolts/pull/1160 The splicing messages are not yet used (on main).
The list of changes (some new fields, some renames):
CommitmentSigned
: New optional batch parameters, used in case multiple commitment are updated at once. Optionalbatch
field of typeCommitmentSignedBatch
, containing batch size and funding txid.TxAddInput
: New optional fieldshared_input_txid
, to be used when during splicing the previous funding transaction is added as an input (funding_txid
).TxSignatures
: Rename optional field toshared_input_signature
, fromfunding_outpoint_sig
.SpliceInit
: Rename msg to SpliceInit, from Splice (msg is nowsplice_init
in spec) (also SendSpliceInit, handle_splice_init)SpliceInit
: Rename amount field tofunding_contribution_satoshis
(fromrelative_satoshis
). Note that his is the part of the initiator only.SpliceInit
: New optional bool fieldrequire_confirmed_inputs
.SpliceInit
: Thechain_hash
field is removed (not needed).SpliceAck
: Rename amount field tofunding_contribution_satoshis
(fromrelative_satoshis
). Note that his is the part of the acceptor only.SpliceAck
: New optional bool fieldrequire_confirmed_inputs
.SpliceAck
: Thechain_hash
field is removed (not needed).SpliceLocked
: Added newsplice_txid
field, with the id of the new locked funding txSpliceInit
andSpliceAck
to80
&81
(from 75 & 76)