search

lightningdevkit / rust-lightning

A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
Other
1.15k stars 363 forks source link

Run `rustfmt` on `lightning-block-sync` #3136

Closed tnull closed 2 months ago

tnull commented 3 months ago

.. this seems like another trivial one.

While we're here, we also drop lightning-custom-message/src/lib.rs from the excluded files, as it doesn't require reformatting.

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 74.29194% with 118 lines in your changes missing coverage. Please review.

Project coverage is 89.76%. Comparing base (dd5d297) to head (12e4efa).

Files Patch % Lines
lightning-block-sync/src/gossip.rs 0.00% 25 Missing :warning:
lightning-block-sync/src/convert.rs 84.66% 13 Missing and 10 partials :warning:
lightning-block-sync/src/rest.rs 29.16% 15 Missing and 2 partials :warning:
lightning-block-sync/src/rpc.rs 55.26% 14 Missing and 3 partials :warning:
lightning-block-sync/src/http.rs 86.31% 12 Missing and 1 partial :warning:
lightning-block-sync/src/init.rs 65.51% 8 Missing and 2 partials :warning:
lightning-block-sync/src/poll.rs 71.87% 5 Missing and 4 partials :warning:
lightning-block-sync/src/lib.rs 90.90% 3 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3136 +/- ## ========================================== - Coverage 89.82% 89.76% -0.06% ========================================== Files 121 121 Lines 100404 100500 +96 Branches 100404 100500 +96 ========================================== + Hits 90187 90217 +30 - Misses 7553 7605 +52 - Partials 2664 2678 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tnull commented 2 months ago

Addressed outstanding feedback.

TheBlueMatt commented 2 months ago

Feel free to squash.

tnull commented 2 months ago

Feel free to squash.

Squashed without further changes:

> git diff-tree -U2 de41b4d03 1494f3bb4
>
tnull commented 2 months ago

Also added a commit dropping lightning-background-processor/src/lib.rs from the exclusion list, which somehow snuck back in even though it was formatted in #3138.