search

lightningdevkit / rust-lightning

A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
Other
1.11k stars 342 forks source link

Followups to #3125 #3145

Closed valentinewallace closed 6 days ago

valentinewallace commented 1 week ago

See https://github.com/lightningdevkit/rust-lightning/pull/3125#discussion_r1651700604 and below.

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.76%. Comparing base (88e1b56) to head (9695787).

Files Patch % Lines
lightning/src/ln/channelmanager.rs 0.00% 9 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3145 +/- ## ========================================== - Coverage 89.83% 89.76% -0.08% ========================================== Files 121 121 Lines 98900 98909 +9 Branches 98900 98909 +9 ========================================== - Hits 88847 88785 -62 - Misses 7457 7522 +65 - Partials 2596 2602 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.