lightningdevkit / rust-lightning

A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
Other
1.15k stars 363 forks source link

Re-export `lightning_types` in top-level `lightning` modules #3253

Closed TheBlueMatt closed 1 month ago

TheBlueMatt commented 1 month ago

Since we now have many types in one place, it makes sense to export them in that place. Further, doing so finally somewhat starts to reduce our lightning::ln module size, which historically is the dumping ground for everything when most things really should be top-level modules in lightning.

Here we take a step in the right direction by exporting lightning_types as lightning::types and encouraging users to use those paths directly rather than the ones in lightning::ln.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.70%. Comparing base (ccce9d9) to head (1e1b8ec). Report is 34 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3253 +/- ## ========================================== + Coverage 89.68% 89.70% +0.01% ========================================== Files 124 124 Lines 102386 102386 Branches 102386 102386 ========================================== + Hits 91827 91844 +17 + Misses 7857 7839 -18 - Partials 2702 2703 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.