Closed TheBlueMatt closed 2 months ago
Attention: Patch coverage is 91.48936%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 89.79%. Comparing base (
bbfa15e
) to head (2ce2fe9
). Report is 10 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
lightning/src/onion_message/messenger.rs | 50.00% | 3 Missing :warning: |
lightning/src/util/test_utils.rs | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks like fuzz code needs to be updated.
Fixed.
We currently have two structs with identical names in our public API -
blinded_path::message::ForwardNode
andblinded_path::payment::ForwardNode
. This makes the API somewhat awkward to use - users have to try (and fail) to importForwardNode
twice only to then have to change their imports.More importantly, however, this makes the API very hard to use in some bindings languages where rename-imports or module imports aren't available.
Thus, here, we rename both to give them context.