lightningdevkit / rust-lightning

A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
Other
1.16k stars 367 forks source link

Add an 0.0.124 CHANGELOG entry #3278

Closed TheBlueMatt closed 2 months ago

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.83%. Comparing base (187a2cb) to head (c9de257). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3278 +/- ## ======================================= Coverage 89.82% 89.83% ======================================= Files 126 126 Lines 103263 103263 Branches 103263 103263 ======================================= + Hits 92754 92763 +9 + Misses 7787 7776 -11 - Partials 2722 2724 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TheBlueMatt commented 2 months ago

Need to add #3276

TheBlueMatt commented 2 months ago

Pushed text for #3285 and squashed. Should be good to go:

$ git diff-tree -U2 05cda3bc2 355f9af84
diff --git a/CHANGELOG.md b/CHANGELOG.md
index d73effe35..4eb7d184b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -122,4 +122,9 @@
    monitors being archived should have no pending updates as they were persisted
    on each new block for some time before archiving (#3276).
+ * `CoinSelection`s selected for commitment transactions which did not contain a
+   change output no longer result in broadcasting a non-standard transaction nor
+   in under-paying the target feerate (#3285). Note that such a transaction
+   would fail to propagate and LDK would have continued to bump the fee until a
+   different `CoinSelection` is used which did contain a change output.
  * `invoice_error`s from BOLT 12 recipients now fail payments (#3085, #3192).
  * Fixed a bug which may lead to a missing `Event::ChannelClosed` and missing
@@ -141,4 +146,6 @@
  * `OnionMessenger::get_update_future` was added, allowing it to wake the
    background processor to ensure `Event`s are processed quickly (#3194).
+ * `CoinSelection`s overpaying the target feerate by more than 1% no longer
+   leads to a debug assertion (#3285).

 ## Backwards Compatibility
$ 
TheBlueMatt commented 2 months ago

Okay, now that #3285 landed included diff stats and put a date on the tin:

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4eb7d184b..121755a12 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,2 +1,2 @@
-# 0.0.124 - XXX, 2024 - "XXX"
+# 0.0.124 - Sep 3, 2024 - "Papercutting Feature Requests"

@@ -183,3 +183,32 @@

-XXX change stats
+In total, this release features 312 files changed, 29853 insertions, 15480
+deletions in 549 commits since 0.0.123 from 26 authors, in alphabetical order:
+
+ * Alec Chen
+ * Arik Sosman
+ * Duncan Dean
+ * Elias Rohrer
+ * Filip Gospodinov
+ * G8XSU
+ * Gursharan Singh
+ * Harshit Verma
+ * Jeffrey Czyz
+ * Jiri Jakes
+ * John Cantrell
+ * Lalitmohansharma1
+ * Matt Corallo
+ * Matthew Rheaume
+ * Max Fang
+ * Mirebella
+ * Tobin C. Harding
+ * Valentine Wallace
+ * Vincenzo Palazzo
+ * Willem Van Lint
+ * benthecarman
+ * cooltexture
+ * esraa
+ * jbesraa
+ * optout
+ * shaavan
+