Closed valentinewallace closed 2 months ago
Attention: Patch coverage is 95.09804%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 89.62%. Comparing base (
6662c5c
) to head (fbb3ab2
). Report is 12 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
lightning/src/ln/outbound_payment.rs | 78.94% | 2 Missing and 2 partials :warning: |
lightning/src/ln/offers_tests.rs | 98.75% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks, yea, I think this looks right, though it'd be nice to include a test that sent the payment MPP.
Adapted the test to use MPP, as a fixup in case you meant a separate test.
Rebased due to silent conflict.
LGTM, feel free to squash IMO.
Squashed.
Kicked CI 🤞
Caught by @TheBlueMatt: https://github.com/lightningdevkit/rust-lightning/pull/3140#discussion_r1752506688.