Open tnull opened 1 week ago
Attention: Patch coverage is 82.12649%
with 195 lines
in your changes missing coverage. Please review.
Project coverage is 89.61%. Comparing base (
4147de2
) to head (bc122e3
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ugh, can we split this? 42 commits in one PR is just a lot...
Ugh, can we split this? 42 commits in one PR is just a lot...
Alright, happy to if you prefer (although at least half of these commits are one-line diffs). Now split out ~the first half of commits to #3324.
Rebased after https://github.com/lightningdevkit/rust-lightning/pull/3327 landed.
Rebased after #3324 landed.
This is PR 2/2, based on #3324.
The diff is a bit larger for this one, but AFAICT the changes look mostly reasonable (besides the oddity commented below).
FWIW, I had a look at currently open inflight PRs and the conflicts should be minimal if I'm not overlooking something.