search

lightningdevkit / rust-lightning

A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
Other
1.17k stars 367 forks source link

Pin `idna_adapter` to fix MSRV #3394

Closed tnull closed 3 weeks ago

TheBlueMatt commented 3 weeks ago

God we need to switch to an HTTP stack which doesn't use url. The massive dep tree just to enable SUPER DUPER FAST parsing of fucking IDNs without the ability to turn them off entirely or do something simple and slow is absolutely insane.

TheBlueMatt commented 3 weeks ago

error: package icu_properties_data v1.5.0 cannot be built because it requires rustc 1.67 or newer, while the currently active rustc version is 1.63.0

tnull commented 3 weeks ago

error: package icu_properties_data v1.5.0 cannot be built because it requires rustc 1.67 or newer, while the currently active rustc version is 1.63.0

Mh, yeah, seems we need to pin it CI-wide... Added a fixup.

tnull commented 3 weeks ago

Do we know why linking in the coverage job is suddenly broken though?

TheBlueMatt commented 3 weeks ago

I haven't had a chance to look into it. It looked like something on codecov's end screwed us.