Open morehouse opened 18 hours ago
MIN_RELAY_FEE_SAT_PER_1000_WEIGHT is used to enforce a minimum fee bump for transaction RBFs. Per Bitcoin Core policy, this should be 1 sat/vB. Instead, we're using 16 sat/vB:
MIN_RELAY_FEE_SAT_PER_1000_WEIGHT
https://github.com/lightningdevkit/rust-lightning/blob/1386bef048eb6082165a3c1e6967c6bb14e1f3e1/lightning/src/chain/chaininterface.rs#L178-L179
This causes RBFs to be much larger than needed in some cases.
We should be using 250 sat/kw, or maybe 253 sat/kw if we need to worry about rounding for the incremental relay feerate.
Oof good catch.
TheBlueMatt
commented
18 hours ago
MIN_RELAY_FEE_SAT_PER_1000_WEIGHTis used to enforce a minimum fee bump for transaction RBFs. Per Bitcoin Core policy, this should be 1 sat/vB. Instead, we're using 16 sat/vB:https://github.com/lightningdevkit/rust-lightning/blob/1386bef048eb6082165a3c1e6967c6bb14e1f3e1/lightning/src/chain/chaininterface.rs#L178-L179
This causes RBFs to be much larger than needed in some cases.
We should be using 250 sat/kw, or maybe 253 sat/kw if we need to worry about rounding for the incremental relay feerate.