Bump lnd compile time dependency to v0.17.0, update RPC compilation of test proto

lightninglabs / aperture

⚡️L402 (Lightning HTTP 402) Reverse Proxy ⚡️

http://l402.tech/

MIT License

233 stars 58 forks source link

Bump lnd compile time dependency to v0.17.0, update RPC compilation of test proto #139

Closed guggero closed 3 days ago

guggero commented 2 weeks ago

Replaces https://github.com/lightninglabs/aperture/pull/138.

starius commented 2 weeks ago

When I run make fmt in the branch, it results in this diff:

diff --git a/pricesrpc/prices.pb.json.go b/pricesrpc/prices.pb.json.go
index 8750a9f..423334e 100644
--- a/pricesrpc/prices.pb.json.go
+++ b/pricesrpc/prices.pb.json.go
@@ -1,6 +1,7 @@
 // Code generated by falafel 0.9.1. DO NOT EDIT.
 // source: prices.proto

+//go:build js
 // +build js

 package pricesrpc

I use Go go1.22.4

guggero commented 2 weeks ago

Hmm, that file is auto generated by falafel. I guess we should update that to use the new format. If I manually format the file then the RPC check CI step will fail. So I'll leave it for now and see if I have time to update falafel at some point. But thanks for noticing!

lightninglabs-deploy commented 1 week ago

@viktortigerstrom: review reminder