URLs in repo with HTTP 404 error response 2024-03-27 edition

[dstadulis]

https://github.com/lightninglabs/docs.lightning.engineering/blob/c7eb3750151f9c3c5707293bf6babc36278d27d2/community-resources/resource-list.md?plain=1#L58 https://github.com/lightninglabs/docs.lightning.engineering/blob/c7eb3750151f9c3c5707293bf6babc36278d27d2/lightning-network-tools/lnd/send-messages-with-keysend.md?plain=1#L56 https://github.com/lightninglabs/docs.lightning.engineering/blob/c7eb3750151f9c3c5707293bf6babc36278d27d2/lightning-network-tools/lnd/send-messages-with-keysend.md?plain=1#L76 https://github.com/lightninglabs/docs.lightning.engineering/blob/c7eb3750151f9c3c5707293bf6babc36278d27d2/the-lightning-network/taproot-assets/taproot-assets-protocol.md?plain=1#L19 https://github.com/lightninglabs/docs.lightning.engineering/blob/c7eb3750151f9c3c5707293bf6babc36278d27d2/docs/lnd/musig2.md?plain=1#L22 https://github.com/lightninglabs/docs.lightning.engineering/blob/c7eb3750151f9c3c5707293bf6babc36278d27d2/docs/lnd/musig2.md?plain=1#L124 https://github.com/lightninglabs/docs.lightning.engineering/blob/c7eb3750151f9c3c5707293bf6babc36278d27d2/lightning-network-tools/aperture/get-aperture.md?plain=1#L42 https://github.com/lightninglabs/docs.lightning.engineering/blob/c7eb3750151f9c3c5707293bf6babc36278d27d2/lightning-network-tools/lnd/rpc-middleware-interceptor.md?plain=1#L139 https://github.com/lightninglabs/docs.lightning.engineering/blob/c7eb3750151f9c3c5707293bf6babc36278d27d2/lightning-network-tools/lnd/channel-acceptor.md?plain=1#L151 https://github.com/lightninglabs/docs.lightning.engineering/blob/c7eb3750151f9c3c5707293bf6babc36278d27d2/lightning-network-tools/lnd/htlc-interceptor.md?plain=1#L297 https://github.com/lightninglabs/docs.lightning.engineering/blob/c7eb3750151f9c3c5707293bf6babc36278d27d2/docs/lnd/INSTALL.md?plain=1#L358 https://github.com/lightninglabs/docs.lightning.engineering/blob/c7eb3750151f9c3c5707293bf6babc36278d27d2/lightning-network-tools/lnd/contribute-to-lnd.md?plain=1#L39 https://github.com/lightninglabs/docs.lightning.engineering/blob/c7eb3750151f9c3c5707293bf6babc36278d27d2/build-a-lapp/local-cluster-setup-with-polar/README.md?plain=1#L5 https://github.com/lightninglabs/docs.lightning.engineering/blob/c7eb3750151f9c3c5707293bf6babc36278d27d2/docs/lnd/release-notes/release-notes-0.16.0.md?plain=1#L516 https://github.com/lightninglabs/docs.lightning.engineering/blob/c7eb3750151f9c3c5707293bf6babc36278d27d2/docs/lnd/grpc/javascript.md?plain=1#L238

[Liongrass]

I checked all these links, and almost all of them are not 404s. I think the issue is how the script picks up the pre-formatted URLs in the raw code (e.g. https://github.com/lightningnetwork/lnd/blob/master/docs/code\_contribution\_guidelines.md), which on the final page show up as https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md and are reachable. Some other links are not displayed on the Builder's Guide.

I found two links that led nowhere, one I updated, the other I removed.

Thank you for the report, I believe the issue can be closed now.

[dstadulis]

almost all of them are not 404s

I just spot checked the bottom 5 and 4 were 404s

one I updated, the other I removed.

Where can I view these changes?

[Liongrass]

If you copy the URLs from the issue above they may appear to be 404s, but if you click on the links in the Builder's Guides they are not 404s. I don't know why this shows up above for example https://github.com/lightninglabs/docs.lightning.engineering/tree/9423e81a91e5a382442d5fa2fdacde019133dbcb/build-a-lapp/lightningpolar.com but in the Builder's Guide it's a functional link to https://lightningpolar.com/.

The last two are not documents from the Builder's Guide, they are documents copied over from the code base, where I assume they live as historical records (especially the 0.16.0 release notes).

The two changes I made yesterday are included in this commit. (Edit, the commit only shows one link from above being removed)