search

lightninglabs / faraday

Lightning Channel Management & Optimization Tool
MIT License
130 stars 29 forks source link

Provide a docker image on dockerhub #175

Open raweber42 opened 10 months ago

raweber42 commented 10 months ago

Is your feature request related to a problem? Please describe. For using the Docker Image, it would be way easier to be able to just pull the image from dockerhub (or any alternative).

Describe the solution you'd like A Docker Image is automatically created (maybe through GitHub Actions?) and pushed to a openly available registry. The Documentation is adjusted accordingly.

Describe alternatives you've considered Let all users build the Docker images themselves.

Additional context Especially useful for a kubernetes setup!

NonsoAmadi10 commented 7 months ago

@guggero do you think this feature is what faraday needs at this time? I don't mind picking this up

guggero commented 7 months ago

Sure, that would be useful. Should be pretty straightforward, just need to copy and adjust https://github.com/lightninglabs/loop/blob/master/.github/workflows/docker.yml

NonsoAmadi10 commented 7 months ago

awesome! I will be picking this up. Thanks! One small question:

Is the docker hub lightninglabs/faraday? @guggero

guggero commented 7 months ago

Is the docker hub lightninglabs/faraday?

Yes. I mean it doesn't exist yet (the first push will create it), but that's the repo name we'd want to use. And it will only work after we've added the required credentials as GitHub repository secrets, which the repo admin will have to do.