search

lightninglabs / lightning-api-ng

Automated API-documentation generation source code for Lightning Lab's FOSS software suite
6 stars 7 forks source link

TXID bytes need to be passed in reverse byte order. #14

Closed CRex15 closed 1 year ago

CRex15 commented 1 year ago

The description for TXID in Label Transaction should include a note that, in the case of GRPC, the TXID needs to be passed in reverse byte order. More info here in the section Searching for TXIDs in the blockchain

jamaljsr commented 1 year ago

Thanks for the suggestion. This change would need to be made in the lnd repo's walletkit.proto file since all of our docs are generated from the protos. Would you like to submit a PR to update it there? If not, we can take care of it.

CRex15 commented 1 year ago

Let me try to do it, yeah!

jamaljsr commented 1 year ago

Cool. Thanks for pointing that out.

Going to close this issue since there are no changes needed in this repo.