lightninglabs / lightning-app

An easy-to-use cross-platform Lightning wallet
GNU General Public License v3.0
901 stars 172 forks source link

Display Touch ID dialog on Android (if supported) #1312

Open kaloudis opened 5 years ago

kaloudis commented 5 years ago

Please hold: waiting for an update to expo

See this comment

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

tanx commented 5 years ago

Please hold: I still need to test on Android. Currently having issues on gomobile init

What’s the error? Make sure to use go@1.13 and upgrade to the newest gomobile and falafel versions.

kaloudis commented 5 years ago

I've updated the code to use theBiometricPrompt api, but it is based on androidx and Expo needs to put out a release with this PR: https://github.com/expo/expo/pull/5521

Otherwise error: package android.support.annotation does not exist gets returned from mobile/node_modules/expo-constants/android/src/main/java/expo/modules/constants/ConstantsService.java

kaloudis commented 5 years ago

@kaloudis thanks for the changes. Looks like this isn't compatible with the current version of expo?

that's correct