Extract all strings into JSON file for en_US

lightninglabs / lightning-app

An easy-to-use cross-platform Lightning wallet

GNU General Public License v3.0

900 stars 172 forks source link

Extract all strings into JSON file for en_US #292

Open tanx opened 6 years ago

tanx commented 6 years ago

For localization.

skv-headless commented 6 years ago

Hello @tanx would love to help here. Just want to suggest instead of keeping everything in 1 file we can keep messages inside components similar to what described here https://medium.freecodecamp.org/internationalization-in-react-7264738274a0. It looks a little bit ugly (https://github.com/iam-peekay/inbox-react-intl/) but seems to be a standart solution.

tanx commented 6 years ago

@skv-headless thanks. I'm currently in the process of massaging the react components to work on iOS and Android so it might be best to wait a bit to tackle this issue, as it would create too much merge pain. I'll ping once we're through with that though.