Stage 2 major review - Githubissues

lightninglabs / lightning-dev-site

Lightning Network Daemon Developer Site

25 stars 40 forks source link

Stage 2 major review #17

Open magomimmo opened 6 years ago

magomimmo commented 6 years ago

I wrote a major review of the stage 2 tutorial, the one on lncli-web.

magomimmo commented 6 years ago

Just take into account that the stage 1 included in this PR is still the one in your master and not the PR I pushed yesterday.

ndeet commented 6 years ago

Hi, I'm no maintainer here but two things:

imho you should not include commits of another PR (https://github.com/lightninglabs/lightning-dev-site/pull/16) into this PR to keep every PR atomic and clean.
please always reference your corresponding issue in your PR so that everybody knows that they belong to each other and can be closed when the PR is merged (this one refers to issue https://github.com/lightninglabs/lightning-dev-site/issues/15)

magomimmo commented 6 years ago

@ndeet you're totally right. My fault. Sorry about that. My only excuse is that this a text repository, not a code repository, but you're right anyway.