gbn: ping and Nack fix - Githubissues

lightninglabs / lightning-node-connect

MIT License

79 stars 22 forks source link

gbn: ping and Nack fix #28

Closed ellemouton closed 2 years ago

ellemouton commented 2 years ago

Turns out, the ping keepalive ticker was never started. This PR:

starts the ping ticker
cleans up the tickers on gbn close
ensures that NACK is handled properly for the case where the peer received the entire queue successfully.

ellemouton commented 2 years ago

I wonder, is there an easy way to add a unit (or integration) test to test the ping handler? A test case that would've caught the problems being fixed here?

yeah good idea... will think about how we can add that 👍