search

lightninglabs / lightning-node-connect

MIT License
78 stars 22 forks source link

itest: export HashmailHarness struct #76

Closed ViktorTigerstrom closed 1 year ago

ViktorTigerstrom commented 1 year ago

This PR exports the HashmailHarness struct, so that it can be used as an external dependency to setup a local mail server.

ellemouton commented 1 year ago

looks like we should maybe update the linter config. Linters like exhaustivestruct have been deprecated :)

ViktorTigerstrom commented 1 year ago

looks like we should maybe update the linter config. Linters like exhaustivestruct have been deprecated :)

Ok thanks, was a bit confused about what's happening with the CI! I will look into that @ellemouton!

ViktorTigerstrom commented 1 year ago

Ok finally got the linter to work properly :)! I updated the config to use a similar config to LND, as I figured it's likely our most up to date linter configs.

I pushed the update linter settings as 2 separate commits to this PR. Let me know if you think it's better that I push them as a separate PR instead @ellemouton!

ViktorTigerstrom commented 1 year ago

Thanks for the review and the feedback @ellemouton! Addressed it with the latest push :)

lightninglabs-deploy commented 1 year ago

@bitromortac: review reminder

ViktorTigerstrom commented 1 year ago

Thanks for the review @bitromortac!

ellemouton commented 1 year ago

@ViktorTigerstrom - the LNC repo prevents me from merging if the commits are not signed (see the "Merging is blocked" warning above)

ViktorTigerstrom commented 1 year ago

Updated the commits' author to my GPG key email address & signed the commits.