search

lightninglabs / lightning-node-connect

MIT License
78 stars 22 forks source link

gbn+mailbox: cleanup & prefixed logger #90

Closed ellemouton closed 7 months ago

ellemouton commented 7 months ago

This PR introduces a prefixed logger which is then passed to the client and server so that their logs are prefixed with (client) and (server) so that we dont have to manually use the isServer variable in logs.

Then, some variables are moved out of the GBN struct and into a new config struct.

depends on #92

ellemouton commented 7 months ago

Also, should I change my packeting bug PRs to be based on this already?

Yeah I think that would be a good idea just so that you get the advantages of the prefixed logger & so that you can take advantage of the slightly cleaner GBN structure.

You can change the base of you PR to gbnCleanup if you want (we must just not forget to change the base of that one before deleting the branch ref after merge)