search

lightninglabs / lightning-terminal

Lightning Terminal: Your Home for Lightning Liquidity
MIT License
511 stars 92 forks source link

Unify the earn rates throughout the application #562

Open Bitcoinite opened 1 year ago

Bitcoinite commented 1 year ago

Is your feature request related to a problem? Please describe. Currently the rates on pool are described in 3 different denominations:

If I see a channel on the Sell Order Board on Pool Lite, I know what APY I need to match in order to fit that order. However, I cannot go to pool and select that APY. Instead, I need to fiddle with the Ask premium in sats until It matches the APY (or I need to calculate it manually).

Describe the solution you'd like Make all earn rates denominated in either % APY, or bps or sats. But not a mix of all 3.

Describe alternatives you've considered Allow users to enter either % APY, or bps, or sats when creating a Bid/Ask order. Currently it is only allowing the enter the total premium in sats.

guggero commented 1 year ago

Is this related to the Pool UI on the lightning terminal user interface? Or the actual Pool command line? If you mean the UI then this issue also needs to be transferred to https://github.com/lightninglabs/lightning-terminal.

Bitcoinite commented 1 year ago

Thanks for pointing that out. I was referring to the pool UI on lightning terminal. The issue does also exist on the pool cli though. I can only set --interest_rate_percent there but not % APY, nor the total premium in sats. This makes it even worse, since the CLI and the GUI offer different input variables when creating an offer.

levmi commented 1 year ago

We have fixes coming soon to unify all of the different options APY/Sats Per Day, so that it's easier to follow and match against orders. Thanks for flagging this though as we'll up the prio on it!