search

lightninglabs / lightning-terminal

Lightning Terminal: Your Home for Lightning Liquidity
MIT License
488 stars 82 forks source link

feat: add keysend messenger to custom permissions #684

Closed secondl1ght closed 7 months ago

secondl1ght commented 7 months ago

Added a new option to the Custom Permissions view when creating a new LNC session. It is called 'Keysend Messenger' which allows to send/receive payments, plus sign messages. This preset can be used in apps such as Cipherchat for example. Users will now also be able to add Sign Message to their Custom permissions as well.

image

secondl1ght commented 7 months ago

Woot! Thanks for the review guys - I adjusted the copy, I agree it reads better this way.

One other thing I was thinking about is that instead of having the expected values for permissionType in a comment, we could change it to use an actual type for these values (see here for the line I am speaking of: https://github.com/lightninglabs/lightning-terminal/pull/684/files#diff-281dcaa6b4e26633152a0b6ce3832cc66285a0ec1d9f1601c3b5bfa56e7855a4R10).

Happy to push one more commit to this PR to add typing to this variable if you guys think it is a good idea.

jamaljsr commented 7 months ago

One other thing I was thinking about is that instead of having the expected values for permissionType in a comment, we could change it to use an actual type for these values (see here for the line I am speaking of: https://github.com/lightninglabs/lightning-terminal/pull/684/files#diff-281dcaa6b4e26633152a0b6ce3832cc66285a0ec1d9f1601c3b5bfa56e7855a4R10).

Happy to push one more commit to this PR to add typing to this variable if you guys think it is a good idea.

Sounds good. Feel free to make that refactoring here in this PR.

secondl1ght commented 7 months ago

Ok cool, I just pushed a commit adding a type. Please let me know what you think! 🙌🏼

levmi commented 7 months ago

Awesome! Really love to see the external contribution here. If you ever want to add anything else to litd or the LNC side, don't hesitate to put up a PR or reach out. Oftentimes, we'll really want to implement something, but not necessarily have the resourcing to prioritize it. This is immensely helpful so thanks!

secondl1ght commented 7 months ago

Awesome thanks everyone! I will definitely continue to contribute to the LL repos when I have some time. 🙂