search

lightninglabs / lightning-terminal

Lightning Terminal: Your Home for Lightning Liquidity
MIT License
488 stars 82 forks source link

Transactions history is downloadable even when txs are not fully fetched #725

Open cjc21 opened 4 months ago

cjc21 commented 4 months ago

I am allowed to download the transaction history even when transactions are still being fetched. The reason I knew transactions are still being fetched is because there is still a running stream of ListInvoices and ListPayments in the dev console.

Expected behavior

Only allow transactions to be downloadable after all of them have been fetched. For a big node with years of transactions, it's hard to know if we are downloading full / partial transactions list if the UI doesn't indicate so.

Actual behavior

I am allowed to download the transaction history even when transactions are still being fetched. Downloading again after waiting a while result in a bigger list of transactions

To reproduce

Download the transaction history. Open dev console and see if ListInvoices or ListPayments is still running. Download again in a few and compare both transaction lists.

System information Standalone lnd-mode litcli version 0.12.2-alpha commit=v0.12.2-alpha, website Linux ip-10-20-128-60 5.15.0-1027-aws #31~20.04.1-Ubuntu SMP Thu Dec 1 19:56:24 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

itsrachelfish commented 4 months ago

Thank you for this feedback, we have been discussing adding a progress bar to the history page to make it more clear that history is still being fetched. I think it makes sense to disable the download button while the results are still loading :+1: